Source Paypal Transaction: enable SAT high strictness #21593

arsenlosenko · 2023-01-19T13:11:15Z

What

Resolving:
#19058

How

Updating SAT config, adding expected records

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

arsenlosenko · 2023-01-19T13:12:10Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/3958767487
❌ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/3958767487
🐛 https://gradle.com/s/chqrmtxdqk65i

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============= 1 failed, 31 passed, 1 skipped in 404.35s (0:06:44) ==============

arsenlosenko · 2023-01-19T15:37:21Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/3959993622
✅ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/3959993622
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_paypal_transaction/utils.py          8      0   100%
source_paypal_transaction/__init__.py       2      0   100%
source_paypal_transaction/source.py       273     18    93%
-----------------------------------------------------------
TOTAL                                     283     18    94%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
=================== 32 passed, 1 skipped in 99.69s (0:01:39) ===================

evantahler

👍 on expected_records looking like sandbox data. I think we can test the stream however, just ignoring the changing column

airbyte-integrations/connectors/source-paypal-transaction/acceptance-test-config.yml

Source Paypal Transaction: enable SAT high strictness

58528ee

arsenlosenko self-assigned this Jan 19, 2023

arsenlosenko linked an issue Jan 19, 2023 that may be closed by this pull request

Source Paypal Transaction: enable high test strictness level in SAT #19058

Closed

octavia-squidington-iv added area/connectors Connector related issues connectors/source/paypal-transaction labels Jan 19, 2023

Allow to use dates in future for incremental tests

3e46d50

arsenlosenko requested review from lazebnyi and darynaishchenko January 19, 2023 15:37

arsenlosenko marked this pull request as ready for review January 19, 2023 15:37

lazebnyi requested a review from evantahler January 19, 2023 19:45

lazebnyi approved these changes Jan 19, 2023

View reviewed changes

evantahler requested changes Jan 19, 2023

View reviewed changes

airbyte-integrations/connectors/source-paypal-transaction/acceptance-test-config.yml Show resolved Hide resolved

lazebnyi requested a review from evantahler January 19, 2023 21:39

evantahler approved these changes Jan 23, 2023

View reviewed changes

evantahler mentioned this pull request Jan 23, 2023

[SAT] ignored_fields key for basic read test #21737

Closed

lazebnyi merged commit 13f568c into master Jan 23, 2023

lazebnyi deleted the arsenlosenko/source-paypal-transaction-high-strictness branch January 23, 2023 22:29

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Paypal Transaction: enable SAT high strictness #21593

Source Paypal Transaction: enable SAT high strictness #21593

arsenlosenko commented Jan 19, 2023

arsenlosenko commented Jan 19, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 19, 2023 •

edited by github-actions bot

Loading

evantahler left a comment

Source Paypal Transaction: enable SAT high strictness #21593

Source Paypal Transaction: enable SAT high strictness #21593

Conversation

arsenlosenko commented Jan 19, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

arsenlosenko commented Jan 19, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Jan 19, 2023 • edited by github-actions bot Loading

Build Passed

evantahler left a comment

Choose a reason for hiding this comment

arsenlosenko commented Jan 19, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 19, 2023 •

edited by github-actions bot

Loading